From cf21c579fac0253ac41b669c7982c9b7209c2723 Mon Sep 17 00:00:00 2001
From: Dave Parker <dave.x.parker@gmail.com>
Date: Thu, 1 Nov 2007 15:11:20 +0000
Subject: [PATCH] Bug fix: MTBDD (ordering=1) construction on modules with no
 vars, eg. ijN.nm.

git-svn-id: https://www.prismmodelchecker.org/svn/prism/prism/trunk@502 bbc10eb1-c90d-0410-af57-cb519fbb1720
---
 prism/src/prism/Modules2MTBDD.java | 18 +++++++++++++-----
 1 file changed, 13 insertions(+), 5 deletions(-)

diff --git a/prism/src/prism/Modules2MTBDD.java b/prism/src/prism/Modules2MTBDD.java
index a2e6995d..a3d50f09 100644
--- a/prism/src/prism/Modules2MTBDD.java
+++ b/prism/src/prism/Modules2MTBDD.java
@@ -438,7 +438,7 @@ public class Modules2MTBDD
 			break;
 			
 		case 2:
-		// ordering: (a ... a) (s l ... l r c ... r c) (s l ... l r c ... r c) ...
+		// ordering: (a ... a) (l ... l) (s r c ... r c) (s r c ... r c) ...
 	
 			// create arrays/etc. first
 			
@@ -492,10 +492,12 @@ public class Modules2MTBDD
 				// if at the start of a module's variables
 				// and model is an mdp...
 				if ((type == ModulesFile.NONDETERMINISTIC) && (last != varList.getModule(i))) {
-					// add scheduling dd var
-					v = JDD.Var(ddVarsUsed++);
-					ddSchedVars[varList.getModule(i)] = v;
-					ddVarNames.add(moduleNames[varList.getModule(i)] + ".s");
+					// add scheduling dd var(s) (may do multiple ones here if modules have no vars)
+					for (j = last+1; j <= varList.getModule(i); j++) {
+						v = JDD.Var(ddVarsUsed++);
+						ddSchedVars[j] = v;
+						ddVarNames.add(moduleNames[j] + ".s");
+					}
 					// change 'last'
 					last = varList.getModule(i);
 				}
@@ -513,6 +515,12 @@ public class Modules2MTBDD
 					ddVarNames.add(varList.getName(i) + "'." + j);
 				}
 			}
+			// add any remaining scheduling dd var(s) (happens if some modules have no vars)
+			for (j = last+1; j <numModules; j++) {
+				v = JDD.Var(ddVarsUsed++);
+				ddSchedVars[j] = v;
+				ddVarNames.add(moduleNames[j] + ".s");
+			}
 			break;
 			
 		default: